Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rem instead of px units used #21367

Closed
1 task done
hadasmaimon opened this issue Jun 8, 2020 · 1 comment
Closed
1 task done

rem instead of px units used #21367

hadasmaimon opened this issue Jun 8, 2020 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@hadasmaimon
Copy link

hadasmaimon commented Jun 8, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

use rem units instead of px units

Examples 🌈

autocomplete
the padding was in pixels and I overrode it
image

Motivation 🔦

it leaves an opportunity for this change to finally be done to conform with ideal application of font-sizes, padding, & spacing that Web platform enables better than what is enabled by pixels.

The same issue in materiel design:
material-components/material-components-web#2731

@hadasmaimon hadasmaimon added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 8, 2020
@oliviertassinari
Copy link
Member

@hadasmaimon Thanks for the issue, I'm closing for #21030, if you want to add anything to the discussion, feel free :).

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants