-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SwipeableDrawer][Drawer] Include a simplified code-source version with only one Drawer, on the Drawer documentation. #20018
Labels
docs
Improvements or additions to the documentation
Comments
I wonder if we really need to show all the positions in a single demo? |
The one we have on the site does anyway. I’m proposing just one side with this, so the code can be easier to implement for developers.
…Sent from my iPhone
On 7 Mar 2020, at 17:10, Matt ***@***.***> wrote:
I wonder if we really need to show all the positions in a single demo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Yes, I'm just questioning whether it's necessary to have the "four side" version. @oliviertassinari ? |
Personally, I think there is no harm keeping this as a second example to demonstrate it.
…Sent from my iPhone
On 7 Mar 2020, at 19:40, Matt ***@***.***> wrote:
Yes, I'm just questioning whether it's necessary to have the "four side" version. @oliviertassinari ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
In any case we can definitely add the simpler version. Would you like to submit a PR? |
… Sent from my iPhone
On 7 Mar 2020, at 22:53, Matt ***@***.***> wrote:
In any case we can definitely add the simpler version. Would you like to submit a PR?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary 💡
Just have second code source example (with sandbox) on the SwipeableDrawer section of the Drawer page.
The current one we have has 4 swipeable drawers from each side of the device. This is good to keep, but a lot of applications might only want it to be swiped from one direction for less complication.
We could keep the newer version as the prime example, and keep the 4 slides version as secondary.
Examples 🌈
This is the example I built:
https://codesandbox.io/s/material-demo-96r4c
Very simple set up.
Motivation 🔦
Just for developers who want to copy an easier version of it to work from. The current code source is just a little bit complicated in its set up. Took me around 10 + minutes bring it to just one drawer and cleaning up the code.
This could lead to including more complicated examples, like a mini variant drawer version (where it remains slightly closed), but it would also only have one drawer.
The text was updated successfully, but these errors were encountered: