-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modal] Zoom out stuck on iPhone (fullscreen) #19117
Comments
What do you think of this diff? diff --git a/packages/material-ui/src/Backdrop/Backdrop.js b/packages/material-ui/src/Backdrop/Backdrop.js
index 543bf6914..2b919c680 100644
--- a/packages/material-ui/src/Backdrop/Backdrop.js
+++ b/packages/material-ui/src/Backdrop/Backdrop.js
@@ -19,8 +19,6 @@ export const styles = {
left: 0,
backgroundColor: 'rgba(0, 0, 0, 0.5)',
WebkitTapHighlightColor: 'transparent',
- // Disable scroll capabilities.
- touchAction: 'none',
},
/* Styles applied to the root element if `invisible={true}`. */
invisible: {
diff --git a/packages/material-ui/src/Modal/SimpleBackdrop.js b/packages/material-ui/src/Modal/SimpleBackdrop.js
index ec76fd345..c15705f26 100644
--- a/packages/material-ui/src/Modal/SimpleBackdrop.js
+++ b/packages/material-ui/src/Modal/SimpleBackdrop.js
@@ -12,8 +12,6 @@ export const styles = {
left: 0,
backgroundColor: 'rgba(0, 0, 0, 0.5)',
WebkitTapHighlightColor: 'transparent',
- // Disable scroll capabilities.
- touchAction: 'none',
},
/* Styles applied to the root element if `invisible={true}`. */
invisible: { Does it fix the issue on your side? Do you want to submit a pull request? I suspect a bug on iOS. This line was introduced to solve #12094 (2018). However, @joshwooding found a better approach, later on, #16162 (2019). I believe we do no longer need this logic :). |
+1, having the same issue using the Modal component. |
@xddz9 Do you want to submit a pull request? :) |
Has a PR being set up for this Issue? I am happy to try and fix it my self if nobody hasn't already. |
@TommyJackson85 As far as I’m aware nothing has been done yet so give it a go :) |
Ok I will try. Would Chrome developer tools be enough to test this on my mobile platforms? Can anybody recommend a better method? |
I tested this on iPhone 11 regular and the bug is with this device also. |
@joshwooding I have similar issue. I am using |
@Karthik922 Upgrade to the latest version |
Dialog Fullscreen does not zoom out after zooming in on IPhone.
We tested this on: IPhone X, SE, XR, 9, 10. Different IOS versions. (IOS 13, 13.3 and 12.4)
Current Behavior 😯
Problem: It does not Zoom Out, user stuck on Zoom.
Expected Behavior 🤔
Expected Behaviour: Screen Zooms Out. (It works on Android)
Steps to Reproduce 🕹
Steps:
Context 🔦
We are using fullscreen Dialog for our mobile app and this has been reported as an issue. Upon investigation we realised this is a MUI bug as we can replicate it with the demo dialog.
Your Environment 🌎
The text was updated successfully, but these errors were encountered: