Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs contains wrong types for props #15413

Closed
2 tasks done
Atralbus opened this issue Apr 19, 2019 · 0 comments · Fixed by #15414
Closed
2 tasks done

Breadcrumbs contains wrong types for props #15413

Atralbus opened this issue Apr 19, 2019 · 0 comments · Fixed by #15414
Labels
bug 🐛 Something doesn't work component: breadcrumbs This is the name of the generic UI component, not the React module! typescript

Comments

@Atralbus
Copy link
Contributor

Atralbus commented Apr 19, 2019 •
edited
Loading

The API doc shows that itemsAfterCollapse and itemsBeforeCollapse have number type and they actually work as expected but they are written as boolean in Breadcrumbs.d.ts

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

itemsAfterCollapse and itemsBeforeCollapse should have number type.

Current Behavior 😯

itemsAfterCollapse and itemsBeforeCollapse have boolean type.

Steps to Reproduce 🕹

Context 🔦

Your Environment 🌎

Tech Version
Material-UI v3.9.2
React v16.8.2
Browser Chrome v73
TypeScript v3.4.3
etc.
@Atralbus Atralbus mentioned this issue Apr 19, 2019
Merged
1 task
@joshwooding joshwooding added typescript bug 🐛 Something doesn't work labels Apr 19, 2019
@oliviertassinari oliviertassinari added the component: breadcrumbs This is the name of the generic UI component, not the React module! label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: breadcrumbs This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Breadcrumbs] Fix types and enable component generic props
3 participants
@oliviertassinari @Atralbus @joshwooding