Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ripple effect bug in mobile. #15393

Closed
shangdev opened this issue Apr 18, 2019 · 5 comments
Closed

The ripple effect bug in mobile. #15393

shangdev opened this issue Apr 18, 2019 · 5 comments
Labels
component: button This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information

Comments

@shangdev
Copy link

shangdev commented Apr 18, 2019

Current Behavior 😯

ripple effect will not recover. The specific performance is like this

image
image

And chrome console have error tips:

image

Steps to Reproduce 🕹

Link: https://psi.sturgeon.mopaasapp.com/#/

  1. open url.
  2. login, user is admin, password is admin.
  3. click icons or button.

Your Environment 🌎

Tech Version
Material-UI v1.1.0
Material-Icons v1.1.0
React master
Browser chrome latest
@eps1lon eps1lon added component: button This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information labels Apr 18, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 18, 2019

It's very hard to debug this without code. Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@shangdev
Copy link
Author

I can't recurrent it in codesandbox.io, This is my code:
https://codesandbox.io/embed/m384k8m3xj

It seems that it should only have this bug in my project, but I don't know what caused this.

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 18, 2019

@shangdev Have a look at the dependencies installed that might change the global behavior of the browser events. For instance: fastclick #7537.

@shangdev
Copy link
Author

shangdev commented Apr 19, 2019

@oliviertassinari

When I disable the fastclick, It work good.
So how to resolve this conflict without removing fastclick? Only uninstall fastclick?

@oliviertassinari
Copy link
Member

I'm not aware of any other solution than to uninstall fastclick. This dependency shouldn't be needed anymore. Mobile browsers, even Safari do no longer have a delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: button This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants