Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG material icon #1475

Closed
oliviertassinari opened this issue Aug 21, 2015 · 8 comments
Closed

SVG material icon #1475

oliviertassinari opened this issue Aug 21, 2015 · 8 comments
Labels
docs Improvements or additions to the documentation

Comments

@oliviertassinari
Copy link
Member

It's not clear in the documentation that all icons of http://google.github.io/material-design-icons/ are availabled as SVG react component.
I believe we should improve the doc.

@metalmatze
Copy link
Contributor

I'd rather use the icon font. 😉 But it's my opinion.

@oliviertassinari
Copy link
Member Author

Yep, it depends on the use case.
For me, SVG is supported, and I don't want to load a massive font, when I'm only using 10% of the available icons.

@owencm
Copy link
Contributor

owencm commented Aug 21, 2015

It's maybe worth noting that using SVG for icons will cause Chrome not to use Ganesh (Chrome's GPU accelerated compositing), so using an icon font containing only the icons you need is best for perf.

@oliviertassinari
Copy link
Member Author

@owencm Good to know! We have a better computation speed with font with Chrome.

What about the network and memory impact.
Let's say I want to minimize the first rendering time of a page. I have 3 icons to render on my screen.
What's best between, using a font with those 3 icons or or using 3 svg react icon components?

@oliviertassinari
Copy link
Member Author

also linked to #1459

@alitaheri alitaheri added the docs Improvements or additions to the documentation label Dec 8, 2015
@oliviertassinari
Copy link
Member Author

The SVG documentation is now far better thanks to #2695 @Zadielerick.

For convenience, the full set of google Material icons are available in Material-UI as pre-built SVG Icon components.

http://www.material-ui.com/#/components/svg-icon

@oliviertassinari
Copy link
Member Author

Thanks @mbrookes for the new wordings too 🚀!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

5 participants