Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardHeader should have same typography/props controls like ListItemText #12115

Closed
kirill-konshin opened this issue Jul 11, 2018 · 4 comments
Closed
Labels
component: card This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@kirill-konshin
Copy link

CardHeader should have same typography/props controls like ListItemText:

<ListItemText primaryTypographyProps={...} secondaryTypographyProps={...}/>
@oliviertassinari oliviertassinari added new feature New feature or request component: card This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels Jul 11, 2018
@oliviertassinari
Copy link
Member

@kirill-konshin Feel free to go ahead.

@chenop
Copy link
Contributor

chenop commented Jul 14, 2018

@oliviertassinari,

  1. What about disableTypography, should it be implemented in CardHeader as well?
  2. should the new props should be named primaryTypographyProps & secondaryTypographyProps? I'm asking cause the relelvant props in CardHeader are title & subheader.

@oliviertassinari
Copy link
Member

What about disableTypography

@chenop I think that supporting disableTypography would be another great addition.

should the new props should be named

It's a good point. It would be better to use the titleTypographyProps and subheaderTypographyProps wording.

@chenop
Copy link
Contributor

chenop commented Jul 16, 2018

#12166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: card This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants