Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Mobile Steppers examples #11155

Closed
1 task done
Klynger opened this issue Apr 26, 2018 · 4 comments
Closed
1 task done

Improvements in Mobile Steppers examples #11155

Klynger opened this issue Apr 26, 2018 · 4 comments
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@Klynger
Copy link
Contributor

Klynger commented Apr 26, 2018

I think the examples of mobile steppers doesn't look so good, because it only shows the component, but doesn't have any content like the others Steppers, so I was thinking in making that examples a little better adding some content to the steps like this sandbox https://codesandbox.io/s/x3rzz63z0p where I'm using the SwipeableViews component and some images. I don't know if that is the best kind of content to the component, because I didn't found any examples in the material spec too, that's why I used images.
I was wondering too if these mobiles steppers can be used as paginators (since there isn't any spec to paginator component in the specs of material design), and if it could, that should be a good example to the docs.
Thank you for read this issue and sorry about my english 😅.

  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Something more of the mobile steppers examples

Current Behavior

Just the mobile stepper component

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. component: stepper This is the name of the generic UI component, not the React module! labels Apr 26, 2018
@oliviertassinari
Copy link
Member

@Klynger Hey, the integration example of the Stepper looks good. Thanks for working on it. If you want to add it into the documentation, we would be happy to review the pull-request :).

@Klynger
Copy link
Contributor Author

Klynger commented Apr 26, 2018

I'll do it 😀. But I still have this doubt about the usage of MobileSteppers as paginators. Do you think this is a good thing to be added in the docs?

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 26, 2018

@Klynger Did you had a look at the specification? The MobileSteppers seems to be here to navigate between different screens on mobile. So, that sounds all right.

@mbrookes
Copy link
Member

I'm kinda with @Klynger here with the concern over this use of the stepper. Not saying it can't be used for a carousel like this, but not sure it should be the main example in the docs.

According to the spec, generally:

Steppers display progress through a sequence of logical and numbered steps. They may also be used for navigation.

In the mobile section, for example:

Use a progress bar when there are many steps, or if there are steps that need to be inserted during the process (based on responses to earlier steps).

"steps to be inserted" seems to suggest the main use case is unchanged. As for "navigation", I don't know that I'd consider stepping through a carousel "navigation".

Nice demo though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

No branches or pull requests

3 participants