Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very slow? #1082

Closed
chuchengcao opened this issue Jul 9, 2015 · 8 comments
Closed

very slow? #1082

chuchengcao opened this issue Jul 9, 2015 · 8 comments
Labels
component: text field This is the name of the generic UI component, not the React module! v0.x

Comments

@chuchengcao
Copy link

my page contains 30 forms, each form contains 10 TextFields and 5 FlatButtons, setState(cause render) will cost 10 seconds

@jkruder
Copy link
Contributor

jkruder commented Jul 9, 2015

@chuchengcao Are your forms all inside the same component?

export default class extends React.Component {
  render() {
    return (
      <form id="form1">
        <TextField ... />
        <TextField ... />
        ...
      </form>
      <form id="form2">
        <TextField ... />
        <TextField ... />
        ...
      </form>
      ...
    );
  }
}

@chrismcv
Copy link
Contributor

chrismcv commented Jul 9, 2015

This is probably related to #1040

@chuchengcao
Copy link
Author

@jkruder Yes. Actually it is like this :

class Form extends React.Component{
 render() {
    return (
      <form>
        <TextField ... />
        <TextField ... />
        <DatePicker ... />
        ...
      </form>
}

class XXForms extends React.Component {
  render() {
    return (
      <div>
        <Form ... />
        <Form ... />
        <Form .../>
        ...
      </div>
    );
  }
}

when I profiling it, i found that "DatePicker" cost about 70% cpu time. And when I use another DatePicker which is not from material-ui, render time reduce to 3s.

@oliviertassinari
Copy link
Member

Witch version of material-ui are you using ?
In the 0.10 I fixed the datepicker performances problem #1059. Can you confirm this with the new release ?

@chuchengcao
Copy link
Author

@oliviertassinari ,
Thank you for replay. My version is 0.9.1, I think it is the same problem. I will confirm it.

@chuchengcao
Copy link
Author

@oliviertassinari I confirmed that performance problem is solved in 0.10.0. :)

@oliviertassinari
Copy link
Member

Perfect 😃

@oliviertassinari
Copy link
Member

Can you close the issue then?

@jkruder jkruder closed this as completed Jul 10, 2015
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added component: text field This is the name of the generic UI component, not the React module! v0.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Development

No branches or pull requests

5 participants