Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[number field]:step incorrect with min #471

Closed
tonyhallett opened this issue Jul 1, 2024 · 2 comments
Closed

[number field]:step incorrect with min #471

tonyhallett opened this issue Jul 1, 2024 · 2 comments
Assignees
Labels
component: number field This is the name of the generic UI component, not the React module!

Comments

@tonyhallett
Copy link

tonyhallett commented Jul 1, 2024

Steps to reproduce

https://codesandbox.io/s/eager-ully-9yvkfn

Steps:

  1. Press plus button - 3 => 4
  2. Press plus button - 4 => 6

Current behavior

Does not adhere to odd steps

Expected behavior

Should be odd stepped.

See https://developer.mozilla.org/en-US/docs/Web/API/ValidityState/stepMismatch
Given <input type="number" min="20" max="40" step="2" /> - step 2

if (value - min) % 2 !== 0, stepMismatch will be true.

This is not an issue with the alpha version mentioned in this issue #41 (comment)
https://codesandbox.io/p/sandbox/winter-meadow-p9x353

Context

No response

Your environment

System:
OS: Windows 11 10.0.22631
Binaries:
Node: 22.2.0 - C:\Program Files\nodejs\node.EXE
npm: 10.8.1 - C:\Program Files\nodejs\npm.CMD
pnpm: Not Found
Browsers:
Chrome: Not Found
Edge: Chromium (126.0.2592.81)
npmPackages:
@emotion/react: ^11.11.4 => 11.11.4
@emotion/styled: ^11.11.5 => 11.11.5
@mui/base: 5.0.0-beta.40
@mui/core-downloads-tracker: 5.15.21
@mui/icons-material: ^5.15.20 => 5.15.20
@mui/material: ^5.15.20 => 5.15.21
@mui/private-theming: 5.15.20
@mui/styled-engine: 5.15.14
@mui/system: 5.15.20
@mui/types: 7.2.14
@mui/utils: 5.15.20
@mui/x-charts: ^7.7.1 => 7.7.1
@mui/x-data-grid: ^7.7.1 => 7.7.1
@types/react: ^18.3.3 => 18.3.3
react: ^18.3.1 => 18.3.1
react-dom: ^18.3.1 => 18.3.1
typescript: ^5.4.5 => 5.4.5

Search keywords: Unstable_NumberInput span NumberInput min

@tonyhallett tonyhallett added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 1, 2024
@zannager zannager added the component: number field This is the name of the generic UI component, not the React module! label Jul 1, 2024
@tonyhallett
Copy link
Author

Sorry this should be moved to https://github.com/mui/material-ui/

@tonyhallett
Copy link
Author

mui/material-ui#42814

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: number field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants