[Paper] Add an optional property component to Paper.d.ts
#27816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes in the tests are wrong. AFAIK the types of the Paper are correct, the issue is with the Drawer. |
oliviertassinari
added
the
PR: needs revision
2 tasks
I'm trying to upgrade my company's design system library that uses MUI as a base. Typing on version 5.4.3 for Paper has no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27703
Problem
Despite
componentproperty has been removed fromPaper.d.ts(perhaps by accident), it's still in the documentation and works (moreover, it's needed, as one can see in the issue above). For consistency with similar components, it's just aReact.ReactNodeChanges
component?: React.ReactNodeproperty back