[core] Batch small changes #19016
Merged
[core] Batch small changes #19016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the polyfils to uncover potential issues and give more confidence when authoring components. Developers should expect our demos to provide the same level of quality than the source. If we need a polyfill to make the docs run, something is probably off.
oliviertassinari
added
the
umbrella
oliviertassinari
force-pushed
the
batch-small-changes-v19
branch
from
e123868 to
67fceb4
Compare
Details of bundle changes.Comparing: 83fb7f4...d960cb9
|
oliviertassinari
force-pushed
the
batch-small-changes-v19
branch
from
67fceb4 to
82e6177
Compare
eps1lon
requested changes
Dec 29, 2019
|
@eps1lon I have updated the Snackbar accessibility visibility guidelines to be more accurate. Thanks for the feedback I'm sorry, I'm not sure to follow. The changes are aimed to be low impact/risk. Revertability and changelog should be "dimensions" we can ignore. Do you see any significant changes that we should worry about? What's the concern with the snackbar? |
mbrookes
reviewed
Dec 29, 2019
Co-Authored-By: Matt <[email protected]>
mbrookes
reviewed
Dec 29, 2019
| @@ -86,27 +86,20 @@ It also enables you to **stack** them on top of one another (although this is di | |||
|
|
|||
| (WAI-ARIA: https://www.w3.org/TR/wai-aria-1.1/#alert) | |||
|
|
|||
| - Since alerts are not required to receive focus, content authors should not require users to close a Snackbar if the role is set to `alert` through the SnackbarContent `role` prop. This is the default role. | |||
| - If a Snackbar requires focus to close it, then content authors should use the `role` of `alertdialog`. | |||
| - By default, the toast won't auto-hide. However, if you decide to use the `autoHideDuration` prop, it's recommended giving users [enough time](https://www.w3.org/TR/UNDERSTANDING-WCAG20/time-limits.html). | |||
There was a problem hiding this comment.
Suggested change
| - By default, the toast won't auto-hide. However, if you decide to use the `autoHideDuration` prop, it's recommended giving users [enough time](https://www.w3.org/TR/UNDERSTANDING-WCAG20/time-limits.html). | |
| - By default, the Snackbar won't auto-hide. However, if you decide to use the `autoHideDuration` prop, it's recommended giving users [enough time](https://www.w3.org/TR/UNDERSTANDING-WCAG20/time-limits.html). |
(A toast is an Android system notification)
There was a problem hiding this comment.
I believe a toast is the generic name for the snackbar (ignoring Material Design language). You can verify this proposition by benchmarking the other design systems.
There was a problem hiding this comment.
http://programmerguru.com/android-tutorial/snackbar-vs-toast/
https://stackoverflow.com/questions/34432339/android-snackbar-vs-toast-usage-and-difference
For your SEO kick, you could add sometimes (mistakenly 😉) referred to as a "toast" to the description. But best not to cause confusing by using a different name in the body text.
|
I have reverted the snackbar's changes and I'm moving them to a dedicated pull request because they seem to raise an ongoing flow of concerns. |
oliviertassinari
force-pushed
the
batch-small-changes-v19
branch
from
083b7f6 to
d960cb9
Compare
This was referenced Feb 23, 2020
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
Dec 5, 2020
The fix applied in mui#19016 is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers should expect our demos to provide the same level of quality as the source.
If we need a polyfill to make the docs run, something is probably off.
[Snackbar] Improve accessibility edb25bf: Leverage https://medium.com/@sheribyrnehaber/designing-toast-messages-for-accessibility-fb610ac364be. The aria-describedby seems to originate from the initial implementation, a long time ago, after a benchmark, and listening to VoiceOver announcement, I believe we can remove it, and simplify the demos :). If it's needed, then it would be great to explain why in the accessibility subsection of the docs page.