-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CardMedia] Use propTypes for "at least one"-check #18384
Merged
eps1lon
merged 2 commits into
mui:master
from
eps1lon:feat/CardMedia/either-prop-warning
Nov 15, 2019
Merged
[CardMedia] Use propTypes for "at least one"-check #18384
eps1lon
merged 2 commits into
mui:master
from
eps1lon:feat/CardMedia/either-prop-warning
Nov 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
new feature
New feature or request
package: material-ui
Specific to @mui/material
labels
Nov 15, 2019
Details of bundle changes.Comparing: 4ce0f41...8dec6d9
|
oliviertassinari
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propTypes
is currently the superior solution to runtime warnings in render methods since it includes component stacks when in ssr (no devtools available) and automatically deduplicates1 messages (something I want to work on in react-devtools regardless).1 We can't polyfill deduplication since propTypes messages are deduplicated based on there component stack. Two warnings with different stacks are not deduplicated. We could only deduplicate every warning regardless of component stack.