[core] Export everything from the second level #18306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.82% , gzip: +0.64% Details of bundle changes.Comparing: aed1f38...bc77b50
|
merceyz
changed the title
|
@merceyz Let me know if you need any assistance with this effort. |
|
Yes please, I don't know what to do about the codemod. As for the import/export, the idea was to just disable that eslint rule |
|
@merceyz I will look at it after dinner :) |
|
@merceyz Updated, let me know what you think about the approach. |
oliviertassinari
approved these changes
Nov 22, 2019
merceyz
commented
Nov 22, 2019
Comment on lines
+57
to
+58
| import withWidth from '@material-ui/core/withWidth'; | ||
| import { isWidthUp } from '@material-ui/core/withWidth'; |
There was a problem hiding this comment.
@oliviertassinari What happened here?
There was a problem hiding this comment.
Previously, isWidthUp wasn't exported from the barrel index.js. With the latest changes, imports can be changed. However, the codemod doesn't support the following case well:
import withWidth, { isWidthUp } from '@material-ui/core/withWidth';It needs two runs to handle it correctly. This breaks the idempotent assertion.
I haven't found how to fix the 2 runs issue. Instead, I have changed the import syntax so the codemod test can be idempotent (equivalent to ignoring the problem).
|
@merceyz Thank you |
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 25, 2019
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 25, 2019
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 25, 2019
2 tasks
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export everything from the second level
Closes #17375