Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Add demo for color prop #18220

Merged
merged 4 commits into from
Nov 7, 2019
Merged

[TextField] Add demo for color prop #18220

merged 4 commits into from
Nov 7, 2019

Conversation

Studio384
Copy link
Contributor

It struck me as odd that there was no demo for this. Given that all color variation demos are done in the first demo, I've added them there.

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 5, 2019 •
edited
Loading

No bundle size changes comparing 7f09ea4...a6e725e

Generated by 🚫 dangerJS against a6e725e

oliviertassinari
oliviertassinari requested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a new demo? Thanks. I think that we should try to keep the demos simple.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: text field This is the name of the generic UI component, not the React module! labels Nov 5, 2019
@Studio384
Copy link
Contributor Author

Where should it be put on the page? Also, should the demo show both styles or only the non-default secondary?

@oliviertassinari
Copy link
Member

@Studio384 I think that showing the secondary color would be enough. What do you think of having it right before "Customized inputs"?

@oliviertassinari oliviertassinari merged commit b29c294 into mui:master Nov 7, 2019
@oliviertassinari
Copy link
Member

@Studio384 Well done 👍

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@LorenzHenk LorenzHenk mentioned this pull request Feb 6, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Studio384 @mui-pr-bot @oliviertassinari @joshwooding