From 9a611c1144222e5e4702a9f1c0a6d16b5c0793a8 Mon Sep 17 00:00:00 2001
From: Daniel Muehlbachler-Pietrzykowski <daniel@muehlbachler.io>
Date: Sat, 26 Oct 2024 19:04:54 +0200
Subject: [PATCH] Issue #534: update checkstyle to 10.19.0

---
 README.md                                                     | 1 +
 config/ant-phase-verify.xml                                   | 1 +
 pom.xml                                                       | 4 ++--
 .../plugins/checkstyle/CheckstyleRulesDefinitionTest.java     | 2 +-
 4 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index e60cb11c..9e3e47a1 100644
--- a/README.md
+++ b/README.md
@@ -17,6 +17,7 @@ Compatibility matrix from Checkstyle:
 
 | Checkstyle Plugin | Sonar min | Sonar max | Checkstyle | Jdk |
 |-------------------|-----------|-----------|------------|-----|
+| 10.19.0           | 9.9       | 10.7+     | 10.19.0    | 11  |
 | 10.17.0           | 9.9       | 10.0+     | 10.17.0    | 11  |
 | 10.16.0           | 9.9       | 10.0+     | 10.16.0    | 11  |
 | 10.15.0           | 9.9       | 10.0+     | 10.15.0    | 11  |
diff --git a/config/ant-phase-verify.xml b/config/ant-phase-verify.xml
index 7a18549d..6177df4f 100644
--- a/config/ant-phase-verify.xml
+++ b/config/ant-phase-verify.xml
@@ -35,6 +35,7 @@
       <property key="checkstyle.importcontroltest.file" file="config/import-control-test.xml"/>
       <property key="checkstyle.suppressions.file" file="config/suppressions.xml"/>
       <property key="checkstyle.suppressions-xpath.file" file="config/suppressions-xpath.xml"/>
+      <property key="checkstyle.java.version" value="11"/>
     </checkstyle>
 
     <tstamp>
diff --git a/pom.xml b/pom.xml
index 07ea530d..6a2db496 100644
--- a/pom.xml
+++ b/pom.xml
@@ -93,13 +93,13 @@
   </ciManagement>
 
   <properties>
-    <checkstyle.version>10.17.0</checkstyle.version>
+    <checkstyle.version>10.19.0</checkstyle.version>
     <sonar.version>9.9.4.87374</sonar.version>
     <sonar.api-version>9.9.0.229</sonar.api-version>
     <maven.sevntu.checkstyle.plugin.version>1.44.1</maven.sevntu.checkstyle.plugin.version>
     <!-- it should be a version of checkstyle that is compatible/compiled with sevntu -->
     <maven.sevntu.checkstyle.plugin.checkstyle.version>
-      10.17.0
+      10.19.0
     </maven.sevntu.checkstyle.plugin.checkstyle.version>
     <antrun.plugin.version>3.1.0</antrun.plugin.version>
     <checkstyle.configLocation>https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-${checkstyle.version}/config/checkstyle-checks.xml</checkstyle.configLocation>
diff --git a/src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java b/src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java
index e82c3d29..c87f2c4c 100644
--- a/src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java
+++ b/src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java
@@ -76,7 +76,7 @@ public void test() {
         // such number should not change during checkstyle version upgrade
         assertThat(duplicatedRuleWithTemplate).hasSize(0);
         // all new Rules should fall in this group
-        assertThat(rulesWithDuplicateTemplate).hasSize(186);
+        assertThat(rulesWithDuplicateTemplate).hasSize(192);
 
         for (RulesDefinition.Rule rule : rules) {
             assertThat(rule.key()).isNotNull();