Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Regex in Settings#Data #607

Closed
ysxninja opened this issue Feb 11, 2024 · 3 comments
Closed

Add Support for Regex in Settings#Data #607

ysxninja opened this issue Feb 11, 2024 · 3 comments
Labels
effort:3 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed prio a

Comments

@ysxninja
Copy link

In Settings#Data Aliases:
Add the ability to specify aliases for any type of entity as regex.
For instance, to be able to define a rule, that all occurrences of .*\bmyapp\b.* e.g. myapp-frontend, myapp-dev, myapp-yetknownfuture are combined under a project called myapp.

@muety
Copy link
Owner

muety commented Feb 11, 2024

hi @ysxninja, thanks for the idea. Will add this as a feature request!

@muety muety added enhancement New feature or request prio b effort:3 labels Feb 11, 2024
@muety muety added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 29, 2024
@muety
Copy link
Owner

muety commented Mar 29, 2024

Had some thoughts about this again. I have a fear that allowing arbitrary regexes from user input might become a security risk, e.g. because of the problem of catastrophic backtracking or potential regex injections.

I'm thinking about implementing glob-like wildcard patterns instead (e.g. app-*). This would be less powerful, but might still suffice for your use cases, @ysxninja @gingerbeardman?

@gingerbeardman
Copy link

Sure thing! I'll probably only use * anyway 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:3 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed prio a
Projects
None yet
Development

No branches or pull requests

3 participants