Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check if class instance still exists in handleRecordingDuration #728

Open
angekouf opened this issue Feb 18, 2021 · 0 comments
Open

No check if class instance still exists in handleRecordingDuration #728

angekouf opened this issue Feb 18, 2021 · 0 comments

Comments

@angekouf
Copy link

angekouf commented Feb 18, 2021

RecordRTC/dev/RecordRTC.js

Lines 217 to 221 in 3585e67

function handleRecordingDuration(counter) {
counter = counter || 0;
counter++;
if (self.blob && self.blob.size) {

There is no check if self still exists when the timeout ends.
That causes an issue in my react app: when the component is unmounted before the recording is stopped, an error occurs saying Cannot read property 'blob' of null.

@angekouf angekouf changed the title No check if class still exists while No check if class instance still exists in handleRecordingDuration Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant