Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Exception handling for /compute/output/{task_id} #92

Open
coltonbh opened this issue Sep 22, 2023 · 0 comments
Open

General Exception handling for /compute/output/{task_id} #92

coltonbh opened this issue Sep 22, 2023 · 0 comments

Comments

@coltonbh
Copy link
Collaborator

Exceptions raised in qcop, e.g., sending a "transition_state" calculation to "psi4" which doesn't support it will result in 500 errors because I don't generically handle exceptions on this endpoint.

The issue is that in qcop I choose to raise certain exceptions upfront before the program is ever called and do not create exc.program_failure objects for them. So these exceptions get raised in ChemCloud and I do not have the associated .input_data to create a proper ProgramFailure objects.

I think the best fix will be to handle ALL exceptions in qcop the same way and append a .program_failure object to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant