Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripper -> Ripper-tags? #38

Open
kwerle opened this issue Oct 21, 2017 · 4 comments
Open

Ripper -> Ripper-tags? #38

kwerle opened this issue Oct 21, 2017 · 4 comments

Comments

@kwerle
Copy link
Contributor

kwerle commented Oct 21, 2017

I notice this uses the ripper gem - which looks pretty ancient. Also I haven't seen it parse anything more than class names in my codebase - which seems weird. And finally, I'm a little confused by the parse code, which is probably more of a me issue.

Anyway - the ripper-tags gem seems up to date and like maybe it'd do a lot of the right things:
https://github.com/tmm1/ripper-tags

@mtsmfm
Copy link
Owner

mtsmfm commented Oct 21, 2017

Hi @kwerle, thank you for your opinion!

I notice this uses the ripper gem - which looks pretty ancient

Ripper isn't a gem. It's a stdlib. So I think it isn't ancient and it always works.
And actually, ripper-tags is using ripper internally.
Ripper is even faster than other parser gems.

I haven't seen it parse anything more than class names in my codebase

Yeah, at this time, the static analysis only works for constants and not perfect 😞

#19 (comment)

I'm a little confused by the parse code, which is probably more of a me issue.

I was just curious about building analyser but now I noticed analysing Ruby code is harder than as I expected.

Of course it's welcome to send PR to use ripper-tags, but please don't remove adhoc things.
adhoc things don't work perfectly for now so I'd like to introduce --experimental flag.

@kwerle
Copy link
Contributor Author

kwerle commented Oct 21, 2017

Yeah, following up I saw that ripper is internal. Ripper tags seems to do a really good job of ctagging - which I figure is a pretty good step in the right direction I've forked a branch of the LS and am going to take a shot at using ripper-tags with it. We'll see how it goes.

It's disappointing that atom-ide does not have a lookup and outline implementation that just uses ctag data - that seems like an obvious first step for all languages.

@NewAlexandria
Copy link

@kwerle did you ever get somewhere on that implementation? Did you find an alt at this point? etc / thanks!

@kwerle
Copy link
Contributor Author

kwerle commented Jul 19, 2022

@kwerle did you ever get somewhere on that implementation? Did you find an alt at this point? etc / thanks!

I use https://github.com/kwerle/ruby_language_server with vscode
https://github.com/kwerle/vscode_ruby_language_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants