Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnOffControl access to commanded setpoint. #457

Open
ldwoolley opened this issue Oct 19, 2022 · 0 comments
Open

OnOffControl access to commanded setpoint. #457

ldwoolley opened this issue Oct 19, 2022 · 0 comments

Comments

@ldwoolley
Copy link

The training description shows the setpoint command signal, but that signal is not available because it was declared under "protected" in the Implementation module for OnOffControl, OnOffControl_WithHisteresis, ConventionalPIControl, and ConventionalOnOffControl. The models all work, and match the data presented in: https://mbe.modelica.university/components/architectures/thermal_control/. However, the data presented compares the actual temperature to the sensor temperature and to the commanded setpoint. You can not plot the setpoint with the current implementation that has the Trapezoid setpoint_signal under a protected declaration. I pulled these out on my copy of the code and was able to access the commands without issue. I ask the question for the creaters, do they intentionally want to hid the setpoint signal behind the protected declaration so the reader has to figure out where the signal went, or do they want the plots to be readily available when the example models are run?

If they want to make a change, I am happy to adjust the code and submit a pull request. Looking for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant