Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign In page #10

Open
cromdenne opened this issue Apr 9, 2012 · 3 comments
Open

Sign In page #10

cromdenne opened this issue Apr 9, 2012 · 3 comments

Comments

@cromdenne
Copy link
Contributor

There's a small problem that I can't seem to find the source of. On the sign in page, if a sign in is unsuccessful then a message pops up at the bottom of the page. However, the message appears outside of the content area, so you can't really see it. It should be really easy to fix, I just can't find where in the html that error is being generated.

@cromdenne
Copy link
Contributor Author

A similar issue arises when you create a new user. There is a welcome message after the user has been created, but the welcome message is outside of the content area so you can can't really tell it's there.

@aeggum
Copy link
Collaborator

aeggum commented Apr 9, 2012

Yeah, those are a ruby/rails thing called flash messages. They are actually generated in the controllers, if I recall correctly. I think that it automatically generates the message in a class called "flash error", when looking at the source. Obviously the problem is that they are generated outside of the < section > tags that they need to be in.

I'm not sure if it will help, but I think the code that deals with it in the html itself is inside the layouts/application.html.erb file. If it can't be in there maybe it can be moved to each file that we have to deal with it in, I'm not sure.

Also, I just fixed some problems with the debug statements at the bottom of the file.

Hope this helps!

@jds0102
Copy link
Collaborator

jds0102 commented Apr 23, 2012

There is also a flash message now that appears after a user requests to have their password reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants