Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add a property 'window' to auditory stimuli #12

Merged
merged 5 commits into from
Aug 18, 2022
Merged

Conversation

mscheltienne
Copy link
Owner

Add a property 'window' which can be set to either None (no-window -> rectangular window) or to a np.ndarray of shape (n_samples,).

@mscheltienne mscheltienne added 🌟 enhancement Proposed improvement or feature request. 🎵 audio Issue with audio module. labels Aug 18, 2022
@mscheltienne mscheltienne self-assigned this Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #12 (7b83d54) into main (42a7369) will increase coverage by 0.08%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   96.25%   96.34%   +0.08%     
==========================================
  Files          34       34              
  Lines        1710     1750      +40     
==========================================
+ Hits         1646     1686      +40     
  Misses         64       64              
Flag Coverage Δ
unittests 96.34% <97.72%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stimuli/audio/base.py 98.38% <94.44%> (+0.23%) ⬆️
stimuli/audio/am.py 100.00% <100.00%> (ø)
stimuli/audio/noise.py 100.00% <100.00%> (ø)
stimuli/audio/sound.py 94.84% <100.00%> (+0.05%) ⬆️
stimuli/audio/tests/test_am.py 100.00% <100.00%> (ø)
stimuli/audio/tests/test_base.py 100.00% <100.00%> (ø)
stimuli/audio/tests/test_tone.py 100.00% <100.00%> (ø)
stimuli/audio/tone.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mscheltienne mscheltienne merged commit 6bd8beb into main Aug 18, 2022
@mscheltienne mscheltienne deleted the windows branch August 18, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 audio Issue with audio module. 🌟 enhancement Proposed improvement or feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant