[bug] Cannot start daemon when ROS_DOMAIN_ID is specified in environment variable #724
Closed
1 task done
Labels
bug
Something isn't working
<Version of the plugin>
v0.8.2
<Copy the Version information from the
Help | About
menu>1.67.1
what is the bug
<current behavior>
When ROS_DOMAIN_ID is specified in the environment variable, the plugin's daemon status is always offine even if ros2 daemon status is running in shell.
Repro steps
<how to reproduce the bug. Please attach sample files or github repo if appropriate.>
expected behavior
<what you would expect to happen>
daemon status is online even if ROS_DOMAIN_ID is set
additional context
<any additional information would be helpful for a better understanding>
I think function getDaemonPort have to add ROS_DOMAIN_ID.
plugin code
vscode-ros/src/ros/ros2/ros2-monitor.ts
Line 12 in 46a674b
cli code
https://github.com/ros2/ros2cli/blob/f4e5952f430e502060594d68f3a050b785fd4249/ros2cli/ros2cli/daemon/__init__.py#L35
The text was updated successfully, but these errors were encountered: