Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary SwiftUI support #8

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

rivera-ernesto
Copy link
Contributor

For now it will simply add a UIHostingController view to the contentView.

I commented out calls needed for proper view controller containment because it doesn’t play well with my UINavigationController.

For now it will simply add a `UIHostingController` `view` to the `contentView`.

I commented out calls needed for proper view controller containment because it doesn’t play well with my `UINavigationController`.
@rivera-ernesto
Copy link
Contributor Author

rivera-ernesto commented Sep 21, 2020

Added code that properly adds/removes the child view controller calling the corresponding methods on both parent and child controllers.

It is cleaner now but it can pose problems with the parent. For instance when using ContaninerController with a UINavigationController it will corrupt push/pop navigation.

Moreover, it would be cleaner to make ContaninerController a proper container UIViewController (currently an NSObject) that is the parent of both the target controller much like a UITabBarController, and the presented controller (currently a view).

@rivera-ernesto
Copy link
Contributor Author

I've noticed that taps in the embed SwiftUI view are not recognized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants