-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with loading Karma test runner #51
Comments
I guess it would be preferable to test for the AMD case first, as is done in https://github.com/umdjs/umd/blob/master/returnExports.js |
@mroderick, so I assume this solution will also resolve the issue #49 |
How does the code not work in the Karma test runner? Did you try modifying PubSubJS to use the UMD pattern linked above? |
This has been fixed with #63, and is included in |
The following code works fine in the browser with AMD but doesn't work in Karma test runner:
In Karma, pubsub is undefined, because it takes the route of common js thinking that
module
is definedThe text was updated successfully, but these errors were encountered: