PubSub.subscribe - check validity of func?

[m-btts]

Would it be possible to add a check to in the subscribe function that func is actually a function. Currently if func is undefined or not a function the error only occurs when the message is published

PubSub.subscribe = function( message, func )

Or do you think this is necessary/unlikely that is it not worth checking?

Many thanks

.

[mroderick]

It's absolutely possible.

I see two ways of handling this.

1. Fail silently
   If there is no function passed to subscribe, then we return false, and do nothing more.
2. Create exception
   If there is no function passed to subscribe, then we throw an exception and do nothing more

While I would prefer option 2, I think that option 1 is a smaller change from current behaviour, so for the sake of easy upgrades, that should probably be the option for now.

Perhaps in v2.x we can throw exceptions when users of the library are doing silly things

[m-btts]

Thank you for the speedy response - failing silently seems a sensible approach for v1.x.

[mroderick]

This has been fixed with #30