Release command fails

[steffans]

I just tried to generate a release however, the package.json gets not updated or commited and i get this error message. Any suggestions?

[mrkmg]

Couple Questions:

• What OS are you on? Win, Linux, Mac?
• What version of GIT are you using?
• How did you invoke generate-release?

[steffans]

I am on a Mac latest OSX, GIT 2.8.3, heres my test setup https://github.com/steffans/test-release/tree/develop

npm run release to run the script.

[mrkmg]

After running a couple tests, this may be related to: nvie/gitflow#98 but I am not completely sure because I am getting different error. Doing more testing.

[steffans]

Thanx, does my test work for you? I also wonder why the message has no quotes in the command.

release finish -m Release 0.0.2 0.0.2

should be

release finish -m "Release 0.0.2" 0.0.2

[mrkmg]

@steffans Could you please try installed the gnu-getopts and let me know i the problem still persists?

https://github.com/petervanderdoes/gitflow-avh/wiki/Installing-on-Mac-OS-X#post-installation-setup-1

[mrkmg]

I just had a successful run on OSX. Please check the updated README for the OSX notes and install git-flow-avh with gnu-getopts.

[steffans]

Thank you! I checked my git flow install, i used the git-flow port. I uninstalled this port and switched to latest git-flow-avh which works even without gnu-getopts

[steffans]

@mrkmg Can you check if there are quotes missing the release finish -m Release 0.0.2 0.0.2 command? The message should be only Release 0.0.2 right?

[mrkmg]

The quotes shouldn't be the problem as I am using spawnSync to spawn the git process and pass the arguments.

I am going to build in a test for proper setting of the release message. Once I have that done I will report back what I am seeing on OSX.

[mrkmg]

I don't have a mac to test on. Can you manually start a release, then finish one with the -m flag and see if the commit message is correct?

[steffans]

Ok done, i have run: git flow release finish 0.1.2 -m 'Release message'

It seems like the version number gets automatically prepended to the release message. So this must be a git flow issue/thing.

[mrkmg]

So I borrow a mac and I got different results. Looking at the source of git-flow-avh now to try to understand what is going on...

[mrkmg]

Okay, so I think I have this resolved. generate-release now detects if you are using the AVH edition, and uses the -f flag to pass the release message. I still recommend that gnu-getopts is installed as on Mac I tested on I was getting problems unless I installed it. I am seeing the correct release message in my tests now and this should be available in version 0.9.0

Please let me know if you are still seeing a problem after the 0.9.0 release. I will close this now, but if you are still having an issue, I will re-open.

[steffans]

@mrkmg Thanks, i will try it.