Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract allowed verbs to a plain txt-file #132

Open
faern opened this issue Mar 22, 2024 · 3 comments
Open

Extract allowed verbs to a plain txt-file #132

faern opened this issue Mar 22, 2024 · 3 comments

Comments

@faern
Copy link
Contributor

faern commented Mar 22, 2024

The fact that the format of the list of allowed verbs is like:

export const SET = new Set([
  'abandon',
  ...
  'write',
]);

Makes it unnecessarily hard to update, sort and maintain. It would be much easier if all the allowed verbs was in a plain textfile, with each verb separated by a single newline (\n). Just like the format of path-to-additional-verbs.

The code to parse that type of list must already be there thanks to the path-to-additional-verbs functionality.

@mristin
Copy link
Owner

mristin commented Mar 22, 2024

Thanks @faern for the suggestion! Indeed an interesting feature.

I only don't know whether it is possible to include a text file in the distribution. @Fryuni would you know more?

@faern
Copy link
Contributor Author

faern commented Mar 22, 2024

But don't let the current release be blocked on this suggestion. I just wanted to leave this here :)

@Fryuni
Copy link
Contributor

Fryuni commented Mar 22, 2024

I only don't know whether it is possible to include a text file in the distribution. @Fryuni would you know more?

GH Actions just clone the entire repo into a folder. If we use all relative paths from the built artifact (using join and resolve with __dirname) it should all work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants