-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use internal crate to share make table functions #16
Conversation
Looks great, much better than copy/paste! Thanks for pushing this past the finish line :) My only comment would be to include a doc-comment at the top of |
@vitiral |
It looks like the only solution is to publish the library crate separately. There might actually be some value to that in this case, as someone might want to create different tables but not depend on this crate. Would it be too much to publish a I'm sorry, I could have sworn I saw a crate that used a path dependency work. Obviously I was mistaken. |
That's fine. Just wanted to check in case we have alternatives. |
@vitiral just published new version with external crate approach |
use internal crate to share make table functions
use internal crate to share make table functions
use internal crate to share make table functions
use internal crate to share make table functions
cc @vitiral
plan to publish new version after land this