Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use internal crate to share make table functions #16

Merged
merged 1 commit into from
Jul 19, 2017
Merged

use internal crate to share make table functions #16

merged 1 commit into from
Jul 19, 2017

Conversation

mrhooray
Copy link
Owner

@mrhooray mrhooray commented Jul 19, 2017

cc @vitiral
plan to publish new version after land this

@vitiral
Copy link
Contributor

vitiral commented Jul 19, 2017

Looks great, much better than copy/paste! Thanks for pushing this past the finish line :)

My only comment would be to include a doc-comment at the top of util/lib.rs to say why it exists.

@mrhooray
Copy link
Owner Author

@vitiral
looks like cargo doesn't support publishing crates with internal crates according to rust-lang/cargo#1565
any suggestions besides publishing this internal crate shared by source and build script?

@vitiral
Copy link
Contributor

vitiral commented Jul 20, 2017

It looks like the only solution is to publish the library crate separately.

There might actually be some value to that in this case, as someone might want to create different tables but not depend on this crate. Would it be too much to publish a crc-core crate or something and then depend on it?

I'm sorry, I could have sworn I saw a crate that used a path dependency work. Obviously I was mistaken.

@mrhooray
Copy link
Owner Author

mrhooray commented Jul 21, 2017

That's fine. Just wanted to check in case we have alternatives.

@mrhooray
Copy link
Owner Author

@vitiral just published new version with external crate approach

mrhooray pushed a commit that referenced this pull request Nov 19, 2017
use internal crate to share make table functions
mrhooray added a commit that referenced this pull request Nov 19, 2017
use internal crate to share make table functions
mrhooray added a commit that referenced this pull request Nov 20, 2017
use internal crate to share make table functions
mrhooray added a commit that referenced this pull request Nov 20, 2017
use internal crate to share make table functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants