Skip to content
This repository has been archived by the owner on Nov 10, 2024. It is now read-only.

Not able to dismiss nor there is any way for continuity #4

Closed
suyashm002 opened this issue Feb 13, 2018 · 7 comments
Closed

Not able to dismiss nor there is any way for continuity #4

suyashm002 opened this issue Feb 13, 2018 · 7 comments

Comments

@suyashm002
Copy link

suyashm002 commented Feb 13, 2018

I am using mGuideView = builder.build();
mGuideView.dismiss();

but unable to dismiss this it is not working . And what if i want to show other icon after how can i do that to maintain continues behaviour . I am using this in fragment

@mreram
Copy link
Owner

mreram commented Feb 13, 2018

maybe using wrong instance of GuideView.
Could you show me your code ?

@mreram
Copy link
Owner

mreram commented Feb 13, 2018

and you can see sample code for continuity
https://github.com/mreram/ShowCaseView/tree/master/app

@suyashm002
Copy link
Author

I am using the same code but in fragment and when click anywhere it is not dismissed

@mreram
Copy link
Owner

mreram commented Feb 13, 2018

my idea was dismissible by clicking on target view
but my future plan is dismissible by clicking outside..

@suyashm002
Copy link
Author

Thank you mreram, nice library . And thanks for quick response let me know if i can contribute to this project to make it more better

@mreram
Copy link
Owner

mreram commented Feb 13, 2018

Thanks,
Pull requests are welcome!
You can improve/fix some part of it .

Add Tests:
Assuming that the code in question already has automated (unit) tests, do add tests for the code you submit.
This isn't a hard rule. There are various cases where you may need to add code without test coverage (e.g. when adding a Object), but if it can be tested, it should be tested.

@mreram
Copy link
Owner

mreram commented Feb 15, 2018

#3 added Dismiss Type

@mreram mreram closed this as completed Feb 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants