New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Add `SpotLight.map` support #29989

Merged

sunag merged 2 commits into mrdoob:dev from sunag:dev-spotlight-map

Nov 28, 2024

+305 −10

Collaborator

sunag commented Nov 28, 2024 •

edited

Loading

Related issue: #29942

Description

Add SpotLight.map support for WebGPURenderer. Unlike WebGLRenderer, turning on .castShadow should be optional.

Add SpotLight.map support.
Add Light.colorNode optional usage
TSL: Add lightShadowMatrix( light ), lightProjectionUV( light )

WebGLRenderer:


          SpotLight: Add .map support

8cd4b3d

sunag added this to the r171 milestone

github-actions bot commented Nov 28, 2024 •

edited

Loading

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	339.14 78.99	339.14 78.99	+0 B +0 B
WebGPU	484.02 134.26	484.46 134.42	+441 B +158 B
WebGPU Nodes	483.49 134.16	483.93 134.32	+441 B +154 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	464.62 111.98	464.62 111.98	+0 B +0 B
WebGPU	552.83 149.53	553.23 149.71	+394 B +172 B
WebGPU Nodes	508.71 139.25	509.11 139.43	+394 B +175 B


          cleanup

3e1764b

sunag marked this pull request as ready for review

November 28, 2024 21:35

sunag merged commit e2e04d3 into mrdoob:dev

12 checks passed

sunag deleted the dev-spotlight-map branch

November 28, 2024 23:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet