LoaderUtils: Deprecate decodeText().
#28278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
May 4, 2024
This reverts commit b76afcd.
ycw
force-pushed
the
remove-decodetext-from-src
branch
from
3b3583c
to
654514b
Compare
ycw
changed the title
decodeText from sourceLoaderUtils.decodeText()
Mugen87
reviewed
May 4, 2024
ycw
force-pushed
the
remove-decodetext-from-src
branch
from
654514b
to
5a5b798
Compare
Mugen87
approved these changes
May 4, 2024
Mugen87
changed the title
LoaderUtils.decodeText()decodeText().
This was referenced May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removesdecodeTextfrom source.This PR deprecates
LoaderUtils.decodeText()According to caniuse,
TextDecoderhas >97% coverage globally., baseline 2017(safari)Available polyfill package: https://www.npmjs.com/package/@loaders.gl/polyfills
I made a simple fiddle for testing the polyfill, it works for utf-8: https://jsfiddle.net/4onckv12/