Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Added dedicated .eslintrc.json #28271

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 3, 2024

three.js sticks to ES2018 ... but the editor codebase uses ES2019 and ES2020 features ... so a dedicated eslintrc is needed.

Dynamic import (ES2020):

const { Rhino3dmLoader } = await import( 'three/addons/loaders/3DMLoader.js' );

const { DRACOExporter } = await import( 'three/addons/exporters/DRACOExporter.js' );

const { GeometryParametersPanel } = await import( `./Sidebar.Geometry.${ geometry.type }.js` );

Optional catch binding (ES2019):

} catch {

@mrdoob mrdoob added this to the r165 milestone May 3, 2024
@mrdoob mrdoob merged commit ed211d8 into mrdoob:dev May 3, 2024
7 of 11 checks passed
@ycw ycw deleted the editor-eslintrc branch May 3, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants