BatchedMesh: addUpdateRanges #27981
Merged
BatchedMesh: addUpdateRanges #27981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
I think this is a good change. There's a potential risk of this being slower to update if too many geometries are updated at once but this use case is why I added multiple update ranges initially - it just never made it in to the class. |
gkjohnson
approved these changes
Mar 24, 2024
marwie
added a commit
to needle-tools/three.js
that referenced
this pull request
Mar 24, 2024
marwie
added a commit
to needle-tools/three.js
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27980
Description
Currently when a BatchedMesh geometry changes the whole buffer is updated via bufferSubData which causes lags when just a part of the buffer has actually changed.
This PR registers the changed range in the BatchedMesh attributes so only the necessary areas are updated
This contribution is funded by 🌵 Needle
Before the change
20240323-160914_Minimal_-_Google_Chrome-logo.mp4
After the change
20240323-160935_Minimal_-_Google_Chrome-logo.mp4