Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferGeometryUtils.computeTangents( geometry ) fails with non-indexed geometry #23795

Closed
WestLangley opened this issue Mar 25, 2022 · 1 comment · Fixed by #23802
Closed

BufferGeometryUtils.computeTangents( geometry ) fails with non-indexed geometry #23795

WestLangley opened this issue Mar 25, 2022 · 1 comment · Fixed by #23802
Assignees
@donmccurdy
Labels
Bug

Comments

@WestLangley
Copy link
Collaborator

WestLangley commented Mar 25, 2022 •
edited
Loading

The error occurs here:

return geometry.copy( _geometry );

when geometry === _geometry.

The proper solution depends on how you intend the method to be used:

geometry = BufferGeometryUtils.computeTangents( geometry ); // return a new geometry

vs.

BufferGeometryUtils.computeTangents( geometry ); // modify the existing geometry

/ping @donmccurdy

  • Three.js version: [r139]
@donmccurdy donmccurdy mentioned this issue Mar 26, 2022
Merged
@donmccurdy
Copy link
Collaborator

Ah thanks for the issue report. It looks like there's another issue (#23716 (comment)) to be fixed as well...

@donmccurdy donmccurdy self-assigned this Mar 26, 2022
@donmccurdy donmccurdy added the Bug label Mar 26, 2022
@donmccurdy donmccurdy mentioned this issue Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donmccurdy donmccurdy

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BufferGeometryUtils: Fixes for MikkTSpace tangents donmccurdy/three.js
2 participants
@WestLangley @donmccurdy