Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directX.x loader bug #12599

Closed
marshall-hunts opened this issue Nov 7, 2017 · 13 comments · Fixed by #12677
Closed

directX.x loader bug #12599

marshall-hunts opened this issue Nov 7, 2017 · 13 comments · Fixed by #12677

Comments

@marshall-hunts
Copy link

marshall-hunts commented Nov 7, 2017

i tried loading my model in the new x-loader but it's returning cannot read property name of null

https://jsfiddle.net/48xkyp1m/

here's the log file:-

three.min.js:173 THREE.WebGLRenderer 88
three.min.js:145 THREE.WebGLRenderer: OES_texture_float_linear extension not supported.
get @ three.min.js:145
XLoader.js:1457 Uncaught TypeError: Cannot read property 'name' of null
at THREE.XLoader.XAnimationObj.make (XLoader.js:1457)
at THREE.XLoader.animationFinalize_step (XLoader.js:1362)
at THREE.XLoader.animationFinalize_step (XLoader.js:1373)
at THREE.XLoader.animationFinalize (XLoader.js:1331)
at XLoader.js:206

Here's the diectx.x model:
https://cdn.rawgit.com/marshall-hunts/game-assets/master/monster.x

@Itee
Copy link
Contributor

Itee commented Nov 7, 2017

@Itee
Copy link
Contributor

Itee commented Nov 8, 2017

The bone 103 named 'Tree' haven't parent. The method make should be protected about case like this, but maybe could you find a work around with this info ?

@Itee
Copy link
Contributor

Itee commented Nov 8, 2017

Here the fiddle with an overload of make methods, i got the skeleton and break geometry but this is a start.

https://jsfiddle.net/n4unsfao/

@mrdoob
Copy link
Owner

mrdoob commented Nov 8, 2017

/ping @adrs2002

@adrs2002
Copy link
Contributor

adrs2002 commented Nov 8, 2017

sorry, i'll check after 12 hours.

but, i made xloader v2.0 is here
https://github.com/adrs2002/threeXfileLoader/blob/v2.0/threeXLoader.js

can you try and report this ?

@marshall-hunts
Copy link
Author

marshall-hunts commented Nov 8, 2017

/ping @adrs2002
update:
https://jsfiddle.net/n4unsfao/4/

seems like it can't read the frame.

i also tried it with this model:

https://cdn.rawgit.com/mrdoob/three.js/r88/examples/models/xfile/SSR06_Born2.x

but's it showing the exact same thing in the log file

@marshall-hunts
Copy link
Author

@Itee
https://jsfiddle.net/n4unsfao/3/

the model loads, but couldn't play the animation
i also tried playing the animation in open3mod and it plays perfectly well

@adrs2002
Copy link
Contributor

adrs2002 commented Nov 8, 2017

@marshall-hunts

this file ( monster.x ) is likely [ scene ] file. 2 skinnedMesh into 1 file.
threeXLoader.js is Support [ one (skinned) Mesh ] file now.

I can try read scene file, but I think it will take some time.

@marshall-hunts
Copy link
Author

@adrs2002
Can you check out this file if it works; it has one skinned mesh

https://cdn.rawgit.com/marshall-hunts/game-assets/master/2monwolv.x

@adrs2002
Copy link
Contributor

adrs2002 commented Nov 8, 2017

@marshall-hunts
thanks file.

[ 2monwolv.x ] is too many allocation bone weights of 1 vertex.
in three.js, max 4 allocate weights of vertex.
Can you fix vertices?

@marshall-hunts
Copy link
Author

@adrs2002
Copy link
Contributor

adrs2002 commented Nov 9, 2017

hmmm.. sorry waiting.
http://adrs2002.com/sandbox/xloader/xfileTest_dummy.html
i think, just a little more.... but I do not know the last one..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants