Skip to content

Commit

Permalink
3DMLoader: Fix typos and reorder imports alphabetically (#27631)
Browse files Browse the repository at this point in the history
* 3DMLoader: Fix typos and reorder imports alphabetically

- Also modify the default MeshStandardMaterial params:
  - change metalness value from 0.8 to 0.1
  - add roughness value at 0.6

* Update 3DMLoader.js

Revert arbitrary changes
  • Loading branch information
GitHubDragonFly authored Jan 29, 2024
1 parent a222a67 commit 6050a4c
Showing 1 changed file with 19 additions and 19 deletions.
38 changes: 19 additions & 19 deletions examples/jsm/loaders/3DMLoader.js
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
import {
BufferGeometryLoader,
FileLoader,
Loader,
Object3D,
MeshStandardMaterial,
MeshPhysicalMaterial,
Mesh,
CanvasTexture,
ClampToEdgeWrapping,
Color,
Points,
PointsMaterial,
DirectionalLight,
DoubleSide,
FileLoader,
LinearFilter,
Line,
LineBasicMaterial,
Loader,
Matrix4,
DirectionalLight,
Mesh,
MeshPhysicalMaterial,
MeshStandardMaterial,
Object3D,
PointLight,
SpotLight,
Points,
PointsMaterial,
RectAreaLight,
RepeatWrapping,
SpotLight,
Sprite,
SpriteMaterial,
CanvasTexture,
LinearFilter,
ClampToEdgeWrapping,
RepeatWrapping,
TextureLoader,
DoubleSide
TextureLoader
} from 'three';

import { EXRLoader } from '../loaders/EXRLoader.js';
Expand Down Expand Up @@ -256,11 +256,11 @@ class Rhino3dmLoader extends Loader {

const pbr = material.pbr;

mat.anisotropy = pbr.anisotropy;
mat.anisotropy = pbr.anisotropic;
mat.anisotropyRotation = pbr.anisotropicRotation;
mat.color = new Color( pbr.baseColor.r, pbr.baseColor.g, pbr.baseColor.b );
mat.clearCoat = pbr.clearCoat;
mat.clearCoatRoughness = pbr.clearCoatRoughness;
mat.clearcoat = pbr.clearcoat;
mat.clearcoatRoughness = pbr.clearcoatRoughness;
mat.metalness = pbr.metallic;
mat.transmission = 1 - pbr.opacity;
mat.roughness = pbr.roughness;
Expand Down

0 comments on commit 6050a4c

Please sign in to comment.