Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrc 6018 - server to node 20 + vitest #233

Merged
merged 11 commits into from
Dec 5, 2024
Merged

Mrc 6018 - server to node 20 + vitest #233

merged 11 commits into from
Dec 5, 2024

Conversation

M-Kusumgar
Copy link
Collaborator

@M-Kusumgar M-Kusumgar commented Nov 15, 2024

This will also serve as the base for future server upgrade stuff, main things here are:

  • changes to config files
  • handlebars to mustache because it is a slimmer dep
  • hot reloading to the server with nodemon

@M-Kusumgar M-Kusumgar changed the base branch from main to mrc-5976 November 15, 2024 11:44
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.61%. Comparing base (5018d12) to head (2a6e5ee).
Report is 34 commits behind head on mrc-5945.

Files with missing lines Patch % Lines
app/server/src/server/views.ts 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mrc-5945     #233      +/-   ##
============================================
- Coverage     99.71%   99.61%   -0.10%     
============================================
  Files           185      183       -2     
  Lines          4542     4462      -80     
  Branches        985      985              
============================================
- Hits           4529     4445      -84     
- Misses           12       15       +3     
- Partials          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@absternator absternator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. Tested and works like a charm.. thanks for running through with me as well..

i wont approve yet since its feature branch

Copy link
Collaborator

@absternator absternator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@M-Kusumgar M-Kusumgar changed the base branch from mrc-5976 to mrc-5945 December 5, 2024 12:19
@M-Kusumgar M-Kusumgar merged commit e2e861d into mrc-5945 Dec 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants