Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimble develop doesn't work; srcDir=src (from nimble file) doesn't exist #111

Closed
timotheecour opened this issue Jan 11, 2021 · 1 comment

Comments

@timotheecour
Copy link

timotheecour commented Jan 11, 2021

  • constantine.nimble shows
srcDir        = "src"

but src doesn't exit

  • after nimble develop inside a fresh clone, import pkg/constantine/primitives.nim doesn't work

probably a consequence of 1st point

related

as mentioned in nim-lang/RFCs#267 (comment), omitting src pollutes scope (eg: I wouldn't want import pkg/helpers/static_for to work as other packages may define their own helpers directory; instead the src prefix is needed such that you can only access it via import pkg/constantine/helpers/static_for), unless nim-lang/RFCs#291 is implemented which gives best of both worlds

@timotheecour timotheecour changed the title nimble develop doesn't work; srcDir=src (from nimble file) doesn't exist nimble develop doesn't work; srcDir=src (from nimble file) doesn't exist Jan 11, 2021
@mratsim
Copy link
Owner

mratsim commented Jan 11, 2021

That's because I used to use src before changing.

I'm not going back to src as long as nimble is dropping it on installation nim-lang/nimble#653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants