feat: add forceNativeWebSocket client option
#1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 37b08c9. Not special support for txiki.js is required thanks to forceNativeWebSocket client option
style: fix lint
robertsLando
requested changes
Jul 25, 2024
robertsLando
requested changes
Jul 25, 2024
chore: remove test_store folder pushed refactor: load protocols only once refactor: use forceNativeWebSocket only for ws choice doc(README): typo + update forceNativeWebSocket behaviour description
robertsLando
changed the title
forceNativeWebSocket client option
|
@EmixamPP Version 5.9.0 published 🚀 |
|
Fast! Thank you! |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #1905 (and could also partially solve #1900).
forceNativeWebSocketoption to the client, if set to true, by-pass theisBrowserdetection by src/lib/is-browser.ts. This allows to easily solve thews does not work in the browserexception for non-standards env/runtime.navigatorof the polyfillesbuild-plugin-polyfill-node, since it defines an arbitrary value for thenavigatorvariable, breaking many usages at runtime of that variable, likenavigator.userAgentornavigator.productwhen using the.esmdist, which then also break the env detection. Instructions forWeChathave been updated.txiki.js, which is now well-supported ifforceNativeWebSocketis used (no need to complicate the code for niche use case).IS_BROWSERtoisBrowser(does not facilitate the task when debugging browser detection).