maxFirstConnects to avoid reconnection loop

[mcollina]

In some cases, we might be stuck in a reconnection loop were we do not expose the internal error to the user. maxFirstConnect  loop should avoid that, so that after X (10) failed attempt to connect for the first time, we give up. Suggested by @jimbojw in #257 (comment)

[5aurabh]

@mcollina I just ran into this issue and am hoping to contribute. Just to get some clarity, should maxFirstConnect be enforced only for the first successful connection or should it be reinforced every time after a successful connection?

Example:
Consider for maxFirstConnect : 0, what would be the desired behaviour if a client is able to successfully connect initially but later on loses connection and tries to reconnect?

[jianfenkezhan]

So, how to fix it?

[jimbojw]

what would be the desired behaviour if a client is able to successfully connect initially but later on loses connection and tries to reconnect?

@5aurabh In that case, the current behavior (retry indefinitely) would be fine. The proposed maxFirstConnect setting would only apply to the initial connection. Once a connection has been made, later reconnection attempts would proceed as normal.

[YoDaMa]

This could be fixed for ECONNREFUSED via #1053

[YoDaMa]

while not explicitly handled, this has been released with #1053 to deal with typical TLS level errors. So we will close this feature request issue.