-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add option to reconnect if connack has an error code #1948
fix: add option to reconnect if connack has an error code #1948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option name looks good to me. Remember to add tests and also docs
I noticed the first pass the CI tests failed for various reasons that ... don't seem related to any changes I made? Esp. the internal error within the codecov uploader. Edit: new runs failed the same way |
@mgabeler-lee-6rs I still don't understand why ci fails, could you try removing the test and push? Just to see if that's the reason |
Trying that, but somehow I suspect that the problem is more likely related to building/uploading from a fork? |
Was going to suggest contacting codecov for help, but I noticed this is using the nodejs uploader, which is deprecated to the point that the repo is archived Might be worth looking into the github action they provide for this now |
That's what I tried here: #1943 But no clue why when I add that action workflow remains in wait state for no reason |
checks on that PR show:
Probably some repo security setting? |
Oh god thanks sooo much for that! I think I lost 4 hours trying to debug that and I totally forgot we have some restrictions on actions that can run.... Could you tell me where you got those errors? I wan't able to see them |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
==========================================
+ Coverage 81.18% 81.21% +0.02%
==========================================
Files 24 24
Lines 1467 1469 +2
Branches 348 349 +1
==========================================
+ Hits 1191 1193 +2
Misses 192 192
Partials 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ok I fixed tests and did a minor refactor, could you please fix conflicts? I moved all tests under |
I clicked into the Checks tab on the PR, and from there (on one of the older commits that failed), into the
On it! |
fixes #1947