fix(browser): add navigator polifilly for wechat mini
#1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
=======================================
Coverage 79.59% 79.59%
=======================================
Files 24 24
Lines 1421 1421
Branches 332 332
=======================================
Hits 1131 1131
Misses 209 209
Partials 81 81 ☔ View full report in Codecov by Sentry. |
robertsLando
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Revert "fix(browser): add `navigator` polifilly for wechat mini (#1796)" This reverts commit c26908a. since the polyfill hardcode navigator, it is impossible to determine the userAgent at runtime * doc(README): update WeChat instructions * feat: add forceNativeWebSocket client option * Revert "feat: add compatibility with txiki.js (#1895)" This reverts commit 37b08c9. Not special support for txiki.js is required thanks to forceNativeWebSocket client option * style: unify import name IS_BROWSER -> isBrowser * fixup! feat: add forceNativeWebSocket client option style: fix lint * fixup! fixup! feat: add forceNativeWebSocket client option chore: remove test_store folder pushed refactor: load protocols only once refactor: use forceNativeWebSocket only for ws choice doc(README): typo + update forceNativeWebSocket behaviour description
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1789