Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/ws is missing from dev dependancies #1340

Closed
jdm-hexagon opened this issue Oct 19, 2021 · 3 comments
Closed

@types/ws is missing from dev dependancies #1340

jdm-hexagon opened this issue Oct 19, 2021 · 3 comments
Assignees

Comments

@jdm-hexagon
Copy link

Not sure if it's omission by design or not, but the type definition for ClientOptions in node_modules/mqtt/types/lib/client-options.d.ts is missing because @types/ws hasn't been added as a dev dependancy, requiring it be added manually to every project that uses mqtt.

@YoDaMa
Copy link
Contributor

YoDaMa commented Oct 19, 2021

good catch not by design. Needs to be added in (although I think @types/ws is relatively new anyways...)

We'll update the dev dependencies.

@YoDaMa
Copy link
Contributor

YoDaMa commented Oct 19, 2021

@vishnureddy17 can you handle this.

@YoDaMa YoDaMa mentioned this issue Oct 19, 2021
@vishnureddy17
Copy link
Member

Looks like this was addressed in #1333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants