Skip TLS SNI if host is IP address #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids showing a warning when the broker address is just an IP [DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version. Same fix as node-postgres has used brianc/node-postgres@d3c8eba
YoDaMa
reviewed
Oct 4, 2021
| var debug = require('debug')('mqttjs:tls') | ||
|
|
||
| function buildBuilder (mqttClient, opts) { | ||
| var connection | ||
| opts.port = opts.port || 8883 | ||
| opts.host = opts.hostname || opts.host || 'localhost' | ||
| opts.servername = opts.host | ||
|
|
||
| if(net.isIP(opts.host) === 0){ |
There was a problem hiding this comment.
so can you explain what is happening here in detail? You're checking if the passed in option on host is an IP address? And then the reason for this is because of something to do with TLS SNI?
There was a problem hiding this comment.
If the server doesn't have a name but only an IP Address in the config then this doesn't try set that IP as the servername for TLS purposes. This avoids a warning at startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids showing a warning when the broker address is just an IP
[DEP0123] DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066. This will be ignored in a future version.
Same fix as node-postgres has used brianc/node-postgres@d3c8eba