fix(browser): prevent error stream.push() after EOF (#1915)

Fixes #1914
mqttjs · Aug 1, 2024 · b5cc835 · b5cc835
1 parent 053a7be
commit b5cc835
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/lib/BufferedDuplex.ts b/src/lib/BufferedDuplex.ts
@@ -56,7 +56,9 @@ export class BufferedDuplex extends Duplex {
 		this.isSocketOpen = false
 
 		this.proxy.on('data', (chunk) => {
-			this.push(chunk)
+			if (!this.destroyed) {
+				this.push(chunk)
+			}
 		})
 	}
 

diff --git a/src/lib/connect/ws.ts b/src/lib/connect/ws.ts
@@ -260,7 +260,9 @@ const browserStreamBuilder: StreamBuilder = (client, opts) => {
 		let { data } = event
 		if (data instanceof ArrayBuffer) data = Buffer.from(data)
 		else data = Buffer.from(data as string, 'utf8')
-		proxy.push(data)
+		if (!proxy?.destroyed) {
+			proxy.push(data)
+		}
 	}
 
 	function socketWriteBrowser(