Test fails due to changes in v8.48.1 → v8.48.2

[mpyw]

• Test using $this->mock(Request::class) always returning empty GET request · Issue #37789 · laravel/framework
• [8.x] Ensure alias is rebound when mocking items in the container by Nacoma · Pull Request #37810 · laravel/framework

In contrary v8.48.1 → v8.48.2 breaks my test...

• Update README.md · mpyw/laravel-cached-database-stickiness@10dc8c7
• laravel-cached-database-stickiness/InitializingTest.php at master · mpyw/laravel-cached-database-stickiness

    public function testInitializationForMailables(): void
    {
        $this->mock(Mailer::class)->shouldReceive('send');

        // [7.x] Multiple Mailers Per App
        // https://github.com/laravel/framework/pull/31073
        if (interface_exists(MailerFactory::class)) {
            $this->mock(MailerFactory::class)
                ->shouldReceive('mailer')
                ->andReturn($this->app->make(Mailer::class));
        }

        DB::connection();

        $this->assertFalse($this->getRecordsModifiedViaReflection());

        Mail::send(new GeneralMailable());

        // ...
}

[mpyw]

@Nacoma 🥺

[mpyw]

Abandoning Laravel's mock() wrapper works well but it still seems to be a "workaround".

$this->app->instance(Mailer::class, \Mockery::mock(Mailer::class, function (MockInterface $mock) {
    $mock->shouldReceive('send');
}));

// [7.x] Multiple Mailers Per App
// https://github.com/laravel/framework/pull/31073
if (interface_exists(MailerFactory::class)) {
    $this->app->instance(MailerFactory::class, \Mockery::mock(MailerFactory::class, function (MockInterface $mock) {
        $mock
            ->shouldReceive('mailer')
            ->andReturn($this->app->make(Mailer::class));
    }));
}

[mpyw]

Mail::getFacadeRoot()

• Previously returns Illuminate\Mail\MailManager
• Now returns Mockery_2_Illuminate_Contracts_Mail_Factory

[mpyw]

laravel/framework#37789 (comment)

I got it!

• @Nacoma's fix is still correct.
• We can't mock drivers delegated by manager's magic methods and macros.
  • In my previous test, MailerFactory was not correctly mocked.

// Without Mocking
Mail::send($mailable);
↓
$mailManager = Mailer::getFacadeRoot();
$mailManager->send($mailable);
↓
$mailManager = Mailer::getFacadeRoot();
$mailManager->__call('send', [$mailable]);
↓
$mailManager = Mailer::getFacadeRoot();
$mailManager->mailer()->send($mailable);

// With Mocking
Mail::send($mailable);
↓
$mailManagerMock = Mailer::getFacadeRoot();
$mailManagerMock->send($mailable);
↓
// Mockery can't find `Mailer::send()` method under `MailManager::__call()` delegation.

How do we get correct approach (not workarounds) for this problem...? @taylorotwell