Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 移除不必要的 moduleId #12

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: 移除不必要的 moduleId #12

wants to merge 1 commit into from

Conversation

F-loat
Copy link
Member

@F-loat F-loat commented Apr 21, 2018 •
edited
Loading

fix Meituan-Dianping/mpvue#312 ，style 没有设置 scoped 属性的话，template 的 moduleId 应该就没有必要存在了

@aOrz
Copy link
Contributor

aOrz commented Apr 27, 2018

还不能直接移除 moduleId，生成 slot 的时候有用到 moduleId

@F-loat
Copy link
Member Author

F-loat commented Apr 27, 2018

嗯，那之后我再看下，另外 div 标签会自动转成 view 标签并加一个 _div 的 class，但是小程序本身的组件就没必要添加 _view 和 _swiper 这些 class 了吧

@aOrz
Copy link
Contributor

aOrz commented Apr 27, 2018

是的，这个地方需要优化下，应该在 https://github.com/mpvue/postcss-mpvue-wxss 里面

@F-loat F-loat mentioned this pull request Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@F-loat @aOrz