Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac: implement VOCTRL_BEGIN_DRAGGING #15377

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

Akemi
Copy link
Member

@Akemi Akemi commented Nov 24, 2024

only works with left clicks.

overlooked by me and follow up of #13582.
also resolves the possible blocker on #15314.

tested with MBTN_LEFT cycle pause and works as expected now.
also tested with following test script that dragging can be triggered by a script with different binding.

local mp = require 'mp'

local function vo_drag()
    mp.command("begin-vo-dragging")
end
mp.add_forced_key_binding('alt+MBTN_LEFT', vo_drag, {complex=true, event=down})

this removes the old isMovableByWindowBackground mechanism with the
newer performDrag(with:) function.
Copy link

Download the artifacts for this pull request:

Windows
macOS

Copy link
Contributor

@kasper93 kasper93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test, but otherwise looks ok.

@Akemi Akemi merged commit 639ef09 into mpv-player:master Nov 27, 2024
26 checks passed
@Akemi Akemi deleted the mac_dragging branch November 27, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants